Update various libraries #2407
Update various libraries #2407
Conversation
Also report gold file name.
This was either +pi or -pi semirandomly, so nolonger testing it.
joshua-cogliati-inl
force-pushed
the
misc_lib_update
branch
from
8d8d388 to
9544362
Compare
|
Job Mingw Test on f03cef1 : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test qsubs sawtooth on 3d876f7 : invalidated by @joshua-cogliati-inl failed in fetch |
Pre 2024.7 automatically squeeze()ed groupby results, so now need to explicitly call squeeze().
joshua-cogliati-inl
force-pushed
the
misc_lib_update
branch
from
3d876f7 to
d38449a
Compare
|
Job Mingw Test on b7b22a0 : invalidated by @joshua-cogliati-inl failed in fetch |
1 similar comment
|
Job Mingw Test on b7b22a0 : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test Fedora 31 on 6cccb51 : invalidated by @joshua-cogliati-inl failed in set python environment |
|
Job Test qsubs sawtooth on 6cccb51 : invalidated by @joshua-cogliati-inl failed in set python environment with segfault |
|
Job Test qsubs sawtooth on 6cccb51 : invalidated by @joshua-cogliati-inl Timeout tests/framework/Optimizers/BayesianOptimizer/Matyas |
|
Job Mingw Test on 6cccb51 : invalidated by @joshua-cogliati-inl failed in fetch |
1 similar comment
|
Job Mingw Test on 6cccb51 : invalidated by @joshua-cogliati-inl failed in fetch |
| @@ -1628,7 +1628,10 @@ def getFundamentalFeatures(self, requestedFeatures, featureTemplate=None): | |||
| ## IND | |||
| #most probabble index | |||
| if len(group['Ind']): | |||
| modeInd = stats.mode(group['Ind'])[0][0] | |||
| try: | |||
There was a problem hiding this comment.
Could you provide a comment here to explain why we need the try except here?
There was a problem hiding this comment.
Hm, depending on version of Scipy, we get a different shaped array because of the change of the keepdims in stats.mode https://docs.scipy.org/doc/scipy/release/1.11.0-notes.html#expired-deprecations
So probably we should just specify keepdims here and use only one of these options.
There was a problem hiding this comment.
I switched it to use an explicit keepdims.
| 2.0,200.0,1,0.005 | ||
| 2.0,400.0,1,0.005 | ||
| 2.0,600.0,1,0.005 | ||
| 2.0,-1000.0,0,0.0025 |
There was a problem hiding this comment.
Could you provide a comment why all values of z are zeros instead of ones?
There was a problem hiding this comment.
I think because the OVO classifier is using:
<ROM name="estimator" subType="LinearRegression">
<Features>X,Y</Features>
<Target>Z</Target>
<fit_intercept>True</fit_intercept>
<normalize>True</normalize>
</ROM>
underneath, and a linear regression is not a good fit for modeling this.
As I mentioned in the commit, this is because of this change: scikit-learn/scikit-learn#22604
There was a problem hiding this comment.
I changed the estimator to Gaussian naive Bayes and the values are now a mixture of zeros and ones.
|
|
@joshua-cogliati-inl This PR is good for me. I have two questions:
|
|
Job Mingw Test on aa1ebb7 : invalidated by @joshua-cogliati-inl failed in fetch |
Pull Request Description
What issue does this change request address?
Closes #2411
What are the significant changes in functionality due to this change request?
Besides the changes that are also in #2250
Drop labelEncoder when pickling KerasBase to support tensorflow 2.14
Convert to tuple before using np.hstack to support numpy 1.26
Explicitly use .squeeze() when needed for to support xarray 2024.7
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.