Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Improvement on Restart Capability #1280

Closed
10 tasks done
wangcj05 opened this issue Jul 16, 2020 · 3 comments · Fixed by #1283
Closed
10 tasks done

[TASK] Improvement on Restart Capability #1280

wangcj05 opened this issue Jul 16, 2020 · 3 comments · Fixed by #1283
Assignees
Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Jul 16, 2020


Issue Description

There are currently several Samplers that do not have the restart capabilities. One reason for that is we do not call the Sampler.finalizeActualSampling(jobHandler,model,myInput) during the restart. The main issue for this is that we need to pass jobHandler to Sampler.finalizeActualSampling, which is not available during restart process. One suggestion is to change it to dict that we can create during restart.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Jul 16, 2020
@wangcj05
Copy link
Collaborator Author

@alfoa @PaulTalbot-INL @joshua-cogliati-inl Please let me know your suggestions.

@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Jul 16, 2020

This is interesting. There may need to be some design in how we do this, especially considering the new Realization objects.

My initial thought, looking over it, is to write something like a receiveSample method that modularizes everything in Steps.MultiRun._localTakeAstepRun from just after for finishedJob in finishedJobs down to jobHandler.termainteJobs, then call that method from inside the if found == 1 in Steps.MultiRun._findANewInputToRun to handle the sample as though it had been sent through the job handler.

@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Jul 23, 2020
@alfoa
Copy link
Collaborator

alfoa commented Jul 23, 2020

Closure checklist passed...

Closure approved via #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants