-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Parser bug with Source Definition #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
critical
An issue that seriously limits user adoption or hampers current use.
parsers are hard
Examples of where MCNP syntax is complicated and should be simplified.
labels
Jul 2, 2024
MicahGale
changed the title
Fixed Parser bug with
Fixed Parser bug with Source Definition
Jul 2, 2024
Merged
tjlaboss
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good unless I've misunderstood anything in the comments I've left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
critical
An issue that seriously limits user adoption or hampers current use.
parsers are hard
Examples of where MCNP syntax is complicated and should be simplified.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a parser bug fix that ultimately led to some bigger infrastructure upgrades.
So #396 was silent because it was able to log errors with parsing, recover, and then parse something slightly meaningful. Changes made to fix this:
None
if there are any errors. This triggers higher up error handling.montepy.data_input
classes for switching out parsers. Instead implemented_load_correct_parser
which updatesself._parser
based on the Input classifier.sdef
has a lot ofd1
etc which is interpreted as a particle and a number in aListNode
. Modified append to never_padd
on formatting based on there being no trailing space.ListNode.append
to only addnever_pad
during the parsing stepDataParser
subclass that parses inputs that are only key-value pairs.sdef
keywords to the tokens to recognize them.Fixes #396, Fixes #427.
Checklist