Add TypeDefinitionDocuments to custom debug information data

[davidwengier]

For .NET 6/C# 10 we added a new CustomDebugInformation type for linking a TypeDef entry to a Document entry, in dotnet/roslyn#56278
This updates ILSpy to correctly display the information.

Before:

After:

The 02 in the value is correct, it refers to the 2nd row of the Document table.

Sorry I took so long to submit this PR :)

[siegfriedpammer]

Thank you for your contribution! Just one question: wouldn't it be better to show the contents of the Document table entry as detail view?

[davidwengier]

Certainly can do that if you'd prefer, it wasn't clear to me whether the detail view should show just the decoded value, or do more. I will update

[siegfriedpammer]

You are of course right. Now I am no longer sure whether adding that information to the details view is a good idea. Maybe it will cause confusion, as one might think that all of the information is present in the blob.

Probably just add a link to the output, which will open the Documents table in a new tab?

Would you want me to add this or do you want to have a look yourself?

[davidwengier]

Is there any example where links are used to navigate between nodes now? I couldn't see anything from a quick look through the app.

In general I think more linking would be great though, for things like values in the "Document" field of the MethodDebugInformation table, or the Parent column of any metadata tables etc. Obviously not as part of this PR though :)

[davidwengier]

Showing the document record is not terrible though:

[siegfriedpammer]

Is there any example where links are used to navigate between nodes now? I couldn't see anything from a quick look through the app.

In general I think more linking would be great though, for things like values in the "Document" field of the MethodDebugInformation table, or the Parent column of any metadata tables etc. Obviously not as part of this PR though :)

See https://github.com/icsharpcode/ILSpy/blob/master/ILSpy/Metadata/GoToTokenCommand.cs#L39 for an example. I can take a closer look tomorrow.

[davidwengier]

See https://github.com/icsharpcode/ILSpy/blob/master/ILSpy/Metadata/GoToTokenCommand.cs#L39 for an example. I can take a closer look tomorrow.

😮

I had no idea that context menu existed!

[siegfriedpammer]

DataGridHyperlinkColumn would probably be a good idea to use for all fields that reference other tables.

[siegfriedpammer]

I have prototyped this... the result is quite good, I think. What do you think?

[davidwengier]

I have prototyped this... the result is quite good, I think. What do you think?

Love it!

[siegfriedpammer]

Thank you very much for your contribution!