Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching iconify 2.0.2 immediately crashes Sketch 70.1 running on M1 mac #16

Open
jink3 opened this issue Nov 27, 2020 · 9 comments
Open

Comments

@jink3
Copy link

jink3 commented Nov 27, 2020

Launching iconify 2.0.2 immediately crashes Sketch 70.1 running on M1 mac. All other plugins are working fine.

@cyberalien
Copy link
Member

Unfortunately I can't replicate that. There is nothing in plug-in that could crash Sketch. All it does at start is it retrieves saved configuration (if it exists) and opens a web view.

Safari could crash Sketch. It currently does crash Sketch when Safari is set to automatically close when closing plug-in, so there is something fishy going on in Sketch communication with Safari.

Can you check if attached plug-in crashes on your computer? It is a basic plug-in created from Sketch template, which uses same web view version (3.4.4) that is used by Iconify plug-in.

my-plugin-name.sketchplugin.zip

@jink3
Copy link
Author

jink3 commented Nov 27, 2020

Hey, thanks for that. Yes, your plugin also crashed Sketch in the exact same way. I'm not really sure what the relationship with Safari is though, I don't use Safari at all on my laptop. Anyhow, hoping my confirmation of the crash helps in some way.

@cyberalien
Copy link
Member

Sketch uses Safari to display user interface for plug-ins.

Thank you very much for testing, it helps a lot. It confirms that issue is with web view, not with Iconify plug-in. That plug-in is created with Sketch template using skpm create my-plugin --template=skpm/with-webview with sketch-module-web-view updated to version 3.4.4.

Can you post a Sketch crash log in skpm/with-webview#25 and any details you can think of? I think it might help developers figure out what's causing crashes.

@jink3
Copy link
Author

jink3 commented Nov 27, 2020

Just posted there, thanks.

@digiklug
Copy link

image

this is the issue i see on big sur and version 70 in case it might help you

@cyberalien
Copy link
Member

Thanks for report, it is a bug in plug-in, but it is different from this issue. I suspect its a bug that I've fixed in Icon Finder earlier today, but haven't pushed to Sketch plug-in yet.

I'll publish update soon.

@cyberalien
Copy link
Member

@digiklug Try 2.0.3, I think it might fix that bug.

@digiklug
Copy link

unfortunately not and now there is another issue
image

@cyberalien
Copy link
Member

Thanks for reporting! Can't replicate it, but will try to figure it out. I've copied your post to #17 because this is a different issue from issue reported by @u-i-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants