Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana cluster connection #405

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Oct 25, 2024

Description:

Commit Message

feat: solana cluster connection

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju added the enhancement New feature or request label Oct 25, 2024
@gcranju gcranju self-assigned this Oct 25, 2024
@gcranju gcranju marked this pull request as ready for review December 11, 2024 05:37
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (106a5f3) to head (c2fa85d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #405   +/-   ##
=========================================
  Coverage     89.29%   89.29%           
  Complexity       77       77           
=========================================
  Files            43       43           
  Lines          2943     2943           
  Branches         37       37           
=========================================
  Hits           2628     2628           
  Misses          298      298           
  Partials         17       17           
Flag Coverage Δ
solidity 88.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gcranju gcranju force-pushed the feat/solana-cluster-connection branch from bbf8e8a to c4ffb80 Compare December 11, 2024 07:22
@gcranju gcranju force-pushed the feat/solana-cluster-connection branch from c4ffb80 to 1a1cab6 Compare December 11, 2024 07:26
@gcranju gcranju requested a review from ibrizsabin December 12, 2024 05:46
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address possibility to return early in sig validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants