Skip the port check for pre-configured "tls-alpn-01" challenge #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the challenge "tls-alpn-01" is pre-configured with MDCAChallenges, mod_md should not check any ports and just set up the challenge. This is a follow-up to icing#133
|
I'm not sure whether the check should be based on |
|
It gets to the point where no longer feel 100% certain what a change in this part really affects. ;-) But I think it is ok and in the spirit of #133. |
|
Thanks! |
mkauf
added a commit
to mkauf/mod_md
that referenced
this pull request
Jan 8, 2020
For "tls-alpn-01" challenges, mod_md checks whether there is a server that supports the "acme-tls/1" protocol. If the challenge "tls-alpn-01" is pre-configured with MDCAChallenges, the ports of the servers are ignored (see issue icing#133). If there are multiple servers matching a domain name, don't just look at the first server but search one that supports the "acme-tls/1" protocol. This is a follow-up to icing#159 and icing#133
mkauf
added a commit
to mkauf/mod_md
that referenced
this pull request
Jan 8, 2020
For "tls-alpn-01" challenges, mod_md checks whether there is a server that supports the "acme-tls/1" protocol. If the challenge "tls-alpn-01" is pre-configured with MDCAChallenges, the ports of the servers are ignored (see issue icing#133). If there are multiple servers matching a domain name, don't just look at the first server but search one that supports the "acme-tls/1" protocol. This is a follow-up to icing#159 and icing#133
mkauf
added a commit
to mkauf/mod_md
that referenced
this pull request
Jan 8, 2020
For "tls-alpn-01" challenges, mod_md checks whether there is a server that supports the "acme-tls/1" protocol. If the challenge "tls-alpn-01" is pre-configured with MDCAChallenges, the ports of the servers are ignored (see issue icing#133). If there are multiple servers matching a domain name, don't just look at the first server but search one that supports the "acme-tls/1" protocol. This is a follow-up to icing#159 and icing#133
tlhackque
pushed a commit
to tlhackque/mod_md
that referenced
this pull request
Mar 6, 2020
Skip the port check for pre-configured "tls-alpn-01" challenge
tlhackque
pushed a commit
to tlhackque/mod_md
that referenced
this pull request
Mar 6, 2020
For "tls-alpn-01" challenges, mod_md checks whether there is a server that supports the "acme-tls/1" protocol. If the challenge "tls-alpn-01" is pre-configured with MDCAChallenges, the ports of the servers are ignored (see issue icing#133). If there are multiple servers matching a domain name, don't just look at the first server but search one that supports the "acme-tls/1" protocol. This is a follow-up to icing#159 and icing#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the challenge "tls-alpn-01" is pre-configured with MDCAChallenges,
mod_md should not check any ports and just set up the challenge.
This is a follow-up to #133