Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup correct peer dependencies #35

Open
ciaranschutte opened this issue Mar 22, 2022 · 0 comments
Open

Setup correct peer dependencies #35

ciaranschutte opened this issue Mar 22, 2022 · 0 comments

Comments

@ciaranschutte
Copy link
Contributor

ciaranschutte commented Mar 22, 2022

I may be wrong, but react and react-dom may still need to be peer deps, so that React doesn't throw mismatching versions for hooks.
That's happened to me while using npm/yarn link.

Originally posted by @caravinci in #33 (comment)

also breaking dev ci

While resolving: @icgc-argo/[email protected]
npm ERR! Found: @emotion/[email protected]
npm ERR! node_modules/@emotion/styled
npm ERR!   peer @emotion/styled@"^11.6.0" from the root project
npm ERR!   @emotion/styled@"^10.0.17" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/addon-info/node_modules/@storybook/theming
npm ERR!     @storybook/theming@"5.3.21" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/addon-info
npm ERR!       dev @storybook/addon-info@"^5.3.21" from the root project
npm ERR!     @storybook/theming@"5.3.21" from @storybook/[email protected]
npm ERR!     node_modules/@storybook/addon-info/node_modules/@storybook/api
npm ERR!       @storybook/api@"5.3.21" from @storybook/[email protected]
npm ERR!       node_modules/@storybook/addon-info/node_modules/@storybook/addons
npm ERR!         @storybook/addons@"5.3.21" from @storybook/[email protected]
npm ERR!         node_modules/@storybook/addon-info
npm ERR!     1 more (@storybook/components)
npm ERR!   1 more (@storybook/theming)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @emotion/styled@"^11.6.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @emotion/[email protected]
npm ERR! node_modules/@emotion/styled
npm ERR!   peer @emotion/styled@"^11.6.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-03-22T21_04_50_693Z-debug-0.log
Error: Process completed with exit code 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant