Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate docusaurus' magic box of routing so links don't break #258

Closed
kcullion opened this issue May 29, 2020 · 9 comments
Closed

Investigate docusaurus' magic box of routing so links don't break #258

kcullion opened this issue May 29, 2020 · 9 comments
Assignees
Labels

Comments

@kcullion
Copy link
Contributor

kcullion commented May 29, 2020

https://drive.google.com/file/d/12a2EcMRPLtcOrjogjCPVXWxkGE77_wfF/view

Problem as seen in video

  • on netlify site sometimes a / gets appended at the end which treats the docs page as a folder and breaks the relative links
  • this happens on QA too (not just netlify)
@kcullion
Copy link
Contributor Author

kcullion commented May 29, 2020

note: for launch, I am going to update all the links to the absolute path and see if that fixes this for now.

Also came across this in the template file...maybe they do want the .md extension when linking to a file
2020-05-29_1544

@ciaranschutte
Copy link
Contributor

@kcullion you are correct. trailing slash is breaking links. Netlify adds it with it's Pretty URL setting.

@ciaranschutte
Copy link
Contributor

facebook/docusaurus#2394

@kcullion
Copy link
Contributor Author

kcullion commented Jun 1, 2020

not so pretty netlify...not so pretty.
I saw it happening on qa too, so to be safe I did the update to all urls on the docs site.

@ciaranschutte
Copy link
Contributor

ciaranschutte commented Jun 1, 2020

https://v2.docusaurus.io/docs/deployment#deploying-to-netlify
@kcullion should be fixed now. I changed the netlify setting

please verify :)

@kcullion
Copy link
Contributor Author

kcullion commented Jun 1, 2020

@ciaranschutte when I go to a netlify link that I had in my browser history, this slash doesn't seem to get added.
Is the QA site also something that will update when new settings get merged? As I still see it happening on pages like https://docs.qa.argo.cancercollaboratory.org/docs/submission-overview

@kcullion
Copy link
Contributor Author

kcullion commented Jun 2, 2020

@rosibaj I feel like we can merge this :)

@rosibaj
Copy link
Contributor

rosibaj commented Jun 2, 2020

moved to awaiting release!

@rosibaj
Copy link
Contributor

rosibaj commented Jun 3, 2020

on production

@rosibaj rosibaj closed this as completed Jun 3, 2020
@rosibaj rosibaj added the SP:2 label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants