You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From a DI perspective, I think it would be much cleaner to replace the ILogger? logger client connection or connection cache arguments with an IClientProtocolConnectionFactory argument. We'd support a logger and a metrics factory decorator and a default factory that provides both logging and metrics.
Our DI extension, could create these decorators if a logger is registered or if services.AddMetrics() is called.
We could consider doing the same for Server if we add IProtocolConnectionListenerFactory.
The text was updated successfully, but these errors were encountered:
We can keep an ILogger convenience constructor that sets up a decorated client connection factory but I think we should provide the option to let the application provide an IClientProtocolConnectionFactory.
It's the DI way, it allows the application to implement custom logging/metrics, it allows to disable our metrics/logger decorators.
From a DI perspective, I think it would be much cleaner to replace the
ILogger? logger
client connection or connection cache arguments with anIClientProtocolConnectionFactory
argument. We'd support a logger and a metrics factory decorator and a default factory that provides both logging and metrics.Our DI extension, could create these decorators if a logger is registered or if
services.AddMetrics()
is called.We could consider doing the same for
Server
if we addIProtocolConnectionListenerFactory
.The text was updated successfully, but these errors were encountered: