Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimagick for transformations #1

Open
8 of 9 tasks
timriley opened this issue Feb 14, 2017 · 0 comments
Open
8 of 9 tasks

Use minimagick for transformations #1

timriley opened this issue Feb 14, 2017 · 0 comments

Comments

@timriley
Copy link
Member

timriley commented Feb 14, 2017

  • Devise a way to encode a series of minimagick operations/arguments into a string
  • For security, see if we can incorporate a pre-shared key into this encoding (i.e. the attache secret key, which is used to verify all the uploads to attache already)
  • Create a decoder for the above
  • Create an object to take the decoded steps and apply them to an image
  • Rip out Paperclip::Thumbnail from Attache::ResizeJob and replace with minimagick operations
  • Rename ResizeJob to ProcessJob or something more generic
  • Handle "original" geometries somehow
  • Remove geometry_whitelist (not needed with HMAC verification)
  • Add performance optimisation back for large images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant