Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource packs #399

Open
PureTryOut opened this issue Sep 28, 2020 · 2 comments
Open

Resource packs #399

PureTryOut opened this issue Sep 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@PureTryOut
Copy link
Contributor

Vanilla Minecraft supports resource packs. They allow for players to customize textures, models, music, sounds, languages, texts such as the end poem, splashes and credits, and fonts, without any code modification.

Preferably resource packs made for vanilla Minecraft would be supported rather than using some custom format.

Do note that Minecraft nowadays supports higher resolution textures than just 16x16. I can't find an exact maximum, but this would have to be supported as well.

@iceiix iceiix added the enhancement New feature or request label Dec 19, 2020
@iceiix
Copy link
Owner

iceiix commented Dec 19, 2020

Would also like to see this, but there are some complications. Stevenarella currently uses the 1.12.x asset format, there is an open PR for updating to 1.13.x+ assets: #71 but ideally we could support both formats

@iceiix
Copy link
Owner

iceiix commented Jan 18, 2021

Investigated this a bit in #483 for #446. src/resources.rs has some support for multiple packs: an InternalPack, bundled within the app containing steven_resources, added in resources::Manager new():

        m.add_pack(Box::new(InternalPack));

The real assets are loaded in load_vanilla() with self.packs.insert() on a DirPack, and load_assets() with self.packs.insert() on an ObjectPack. So there is some support for "resource packs" internally.

For having resource packs as a user-visible feature, we would need UI (add a new page in src/screens) to select and manage resources::Manager packs, including adding new packs from disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants