Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.11 in CI #261

Closed
mlincett opened this issue Mar 23, 2023 · 5 comments
Closed

Support python 3.11 in CI #261

mlincett opened this issue Mar 23, 2023 · 5 comments

Comments

@mlincett
Copy link
Collaborator

We should add python 3.11 in CI.

Currently there may be some problems (see python-poetry/poetry#7686) due to poetry being picky about invalid wheel files.

Also we should decide how many versions of python we should keep testing against.

@mlincett
Copy link
Collaborator Author

Draft PR #262 has been opened to track this.

@mlincett
Copy link
Collaborator Author

Issue at debugpy: microsoft/debugpy#1246

@robertdstein
Copy link
Member

I'm not sure what the best thing here is. We could edit the CI to do the "modern installer = False" option, or pin poetry 1.4.0. I have the impression that poetry will not "fix this" in future versions, since they view it as a check and the upstream repos like debugpy are the source of the problem because their wheels aren't correctly generated.

On the python versions point, I would think it makes sense to test all the ones we currently do, since that costs nothing, but to not commit to maintaining compatibility. As soon as we have a good reason to drop an old version, e.g new-style code incompatible with e.g python 3.8, then we should just drop that version.

@mlincett
Copy link
Collaborator Author

mlincett commented Mar 30, 2023

Thanks for the feedback @robertdstein . I was honestly thinking of sitting on this for a reasonable amount of time to see whether the situation can be resolved upstream without us having to implement and follow-up workarounds. It seems Microsoft is aware there's an issue, they just mentioned it's high priority.

@mlincett
Copy link
Collaborator Author

Seems the issues are fixed upstream, so I am merging the pending PR now.

Will add 3.12 as soon as setup-python will support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants