Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom field: International Telephone Input #368

Closed
iamstevendao opened this issue Dec 27, 2017 · 9 comments
Closed

Custom field: International Telephone Input #368

iamstevendao opened this issue Dec 27, 2017 · 9 comments

Comments

@iamstevendao
Copy link

Please check out my form input.
I tested to integrate with vue-form-generator.
I would be really awesome if you guys put it as one of the fields

my package:
https://www.npmjs.com/package/vue-tel-input

@ChadTaljaardt
Copy link

You should create a pull request adding this to the optional fields available.

@zoul0813
Copy link
Member

zoul0813 commented Jan 9, 2018

I would recommend just building this out as a separate package. I'm hoping that with v3 we will be removing the optional fields from the main code and breaking them out into separate packages ... this way, you don't have to have X, Y and Z optional fields enabled just because you want to use A, B and D optional fields. Most of the optional fields also have extra dependencies, which can be handled in the optional fields package removing the need for you to make sure they are installed.

We can very likely add a link to this project in the docs ... @icebob ?

@icebob
Copy link
Member

icebob commented Jan 9, 2018

Yes, we can add it to the docs as 3rd party field.

@ChadTaljaardt
Copy link

In the mean time why not allow it as a optional field until V3 is out, if there is a pull request.

Whats the ETA for V3?

@zoul0813
Copy link
Member

zoul0813 commented Jan 9, 2018

v3 is being actively worked on, and I don't think we have any timelines for it.

Adding more stuff to v2 just clutters it up. If your package can be installed separately, that would be preferred as it would then be truly "optional". It also allows the code to be maintained by you, without requiring the VFG team to review and approve changes to it as well as handle any issues being reported about it which just slows down our progress on v3 development and existing v2 issues.

Thanks for the contribution, the package looks promising from what I saw on npmjs.com

@iamstevendao
Copy link
Author

Thanks guys for such a great work!
I am using this package as a custom field of VFG in my company's project so I was about to make it support VFG as default for everyone. But I do understand your thoughts so I will make a more detailed document for using it as a custom field of VFG in the README. And it would be awesome if this package has a chance to be in your docs.

@ChadTaljaardt
Copy link

Thanks for your work @iamstevendao

I require this so im looking forward to seeing the implementation!

zoul0813 added a commit that referenced this issue Jan 24, 2018
zoul0813 added a commit that referenced this issue Jan 24, 2018
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this issue Feb 1, 2018
* master:
  removed extra paren
  fixed markdown link
  resolves vue-generators#368 added vue-tel-input
@zoul0813
Copy link
Member

@lionel-bijaoui this project does not seem to support VFG anymore, should we remove it from the README.md? It looks like the project is now a stand-alone custom component for Vue, and does not have any VFG support in it ... all references to VFG were removed from the projects README as well.

@iamstevendao
Copy link
Author

Hi guys, I just added the usage for using vue-tel-input along with vue-form-generator back to README. https://github.com/EducationLink/vue-tel-input#use-as-a-custom-field-of-vue-form-generator.
It should not be a problem anymore right? @zoul0813

@zoul0813 zoul0813 closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants