Added option to use generics with the compile
method
#146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for generics on the
compile
method in order to take advantage of the Typescript validation when we are defining the schema as a param.Usage (before):
Usage (after):
I've set the
T
default value toany
so thecompile
method can still be used without generics.The most concerning part for me, regarding this commit, is that I've changed the
ValidationSchema
from interface to type. I've checked the code and I couldn't find any possible issue with it but I'm not totally sure about all the consequence. So please let me know if you find something.If everything it's alright, I will continue with other PRs.