Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: why react-router is peer dependency instead of react-router-dom? #59

Closed
sitek94 opened this issue Jul 10, 2022 · 3 comments
Closed

Question: why react-router is peer dependency instead of react-router-dom? #59

sitek94 opened this issue Jul 10, 2022 · 3 comments
Labels
question Further information is requested suggestion

Comments

@sitek94
Copy link

sitek94 commented Jul 10, 2022

Hey there! 👋

I'm wondering why react-router is set as peer dependency and not react-router-dom, which is officially recommended?

I'm asking only out of curiosity, because I got this warning:

Screen Shot 2022-07-10 at 20 09 58
@icd2k3
Copy link
Owner

icd2k3 commented Jul 20, 2022

It's mostly because react-router is compatible with both web DOM and react native... I'm considering switching to react-router-dom and perhaps splitting out a different version of this util for native (if there's any demand) 🤔

@icd2k3 icd2k3 added question Further information is requested suggestion labels Jul 20, 2022
@icd2k3 icd2k3 mentioned this issue Sep 9, 2022
Merged
@icd2k3
Copy link
Owner

icd2k3 commented Sep 9, 2022

v4.0.0

@icd2k3 icd2k3 closed this as completed Sep 9, 2022
@sitek94
Copy link
Author

sitek94 commented Sep 9, 2022

Thanks both for explaining and migrating to react-router-dom, cheers! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icd2k3 @sitek94