Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate vp_list.txt on the collector automatically from ansible #10

Open
wtoorop opened this issue Jun 11, 2024 · 3 comments
Open

Generate vp_list.txt on the collector automatically from ansible #10

wtoorop opened this issue Jun 11, 2024 · 3 comments

Comments

@wtoorop
Copy link
Contributor

wtoorop commented Jun 11, 2024

Alternative deployments, besides having to provision the list of vantage points in the inventory in the “Local” directory, also need to adapt the vp_list.txt file on the collector with their list of vantage points manually. The vp_list.txt file could be generated from the inventory as well.

Would you consider a PR that would implement this?

@paulehoffman
Copy link
Contributor

Alternative deployments differ from RSSAC047. Please ask your sponsors before working on this. If they say that adding features that are not in RSSAC047 is part of your contract, and that we can have a "do this as RSSAC047" configuration setting that is on by default, adding those features is just fine.

@wtoorop
Copy link
Contributor Author

wtoorop commented Jun 11, 2024

Alternative deployments differ from RSSAC047.

Sorry for not being clear. I didn't mean an alternative deployment, but just a deployment of the initial implementation in this repository that completely follows RSSAC047v2 guidelines outlined in section 3 of RSSAC047v2.

Also my usage of the word "feature" was probably wrong. The proposal was to help eliminate the hardcoded constants that are part of the deployment configuration and not of the implementation. Other than the vp_list.txt no deployment configuration is hardcoded in the implementation. Besides that, the list of vantage points is also in your ansible inventory, right?

@paulehoffman
Copy link
Contributor

I think I see where you are going on this, and that sounds fine. Do it as a PR and I'll only object if it doesn't follow 047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants