Confusion in test_label_eligible apply_reflexive_mapping

[TonyStew]

In core.test_label_eligible we're calling _test_label_disposition like so:
(disposition, action_idx) = self._test_label_disposition(label, apply_reflexive_mapping=not is_variant)

But the apply_reflexive_mapping param of _test_label_disposition is described as:

apply_reflexive_mapping: Whether the reflexive mapping should be considereed for disposition
(This should be True when evaluating a variant)

Is it correct that we're inverting is_variant here? That seems contradictory with the comment.

[j-bernard]

Thanks for reporting this.

IIRC, when doing the implementation, the logic was initially inverted. So it seems the comment is tied to the initial implementation.

The associated commit message matches with the logic that is implemented:

Stop considering reflexive mapping when evaluating a variant label

Will fix the comment for the next release.