Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement floating date/time in CalDateTime #647

Open
axunonb opened this issue Nov 21, 2024 · 0 comments
Open

Implement floating date/time in CalDateTime #647

axunonb opened this issue Nov 21, 2024 · 0 comments
Labels
version 5

Comments

@axunonb
Copy link
Collaborator

axunonb commented Nov 21, 2024

A floating date/time means, there is no timezone defined. The floating date/time is the same in all timezones.
To discuss: Remove CTOR overloads with DateTime
@axunonb axunonb mentioned this issue Nov 21, 2024
Open
axunonb added a commit to axunonb/ical.net that referenced this issue Nov 21, 2024
@axunonb
Implement review comments
320d624 
* `if (Math.Abs(right.TotalDays % 1) > AlmostZeroEpsilon)` is now `if ((right.Ticks % TimeSpan.TicksPerDay) != 0)`
* `DateUtil.DateTime GetSimpleDateTimeData(IDateTime dt)` returns `dt.Value`
* Move internal `DateUtil.SimpleDateTimeToMatch` as private to `RecurrenceTests`
* Move internal `DateUtil.MatchTimeZone` as private  to `RecurrencePatternEvaluator`
* Create tasks in ical-org#646 and ical-org#647 for new PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
version 5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axunonb