Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDATE deserialization: Can't keep apart Periods and Dates/Times #570

Open
minichma opened this issue Mar 27, 2023 · 3 comments
Open

RDATE deserialization: Can't keep apart Periods and Dates/Times #570

minichma opened this issue Mar 27, 2023 · 3 comments

Comments

@minichma
Copy link
Collaborator

RDATEs are represented in ical.net as PeriodList and therefore, when it comes to deserialization, the values of RDATEs are deserialized to instances of Period. According to the RFC RDATEs can hold any of the following value types "DATE-TIME" / "DATE" / "PERIOD".

Problems:

  • The information about the actual value type is lost in the Period instance. (It's still somehow accessible when looking at the PeriodList's parameters, but this doesn't seem to the intended way of using the type.)
  • The information about the source of the duration is lost. I.e. looking at the Period it's unclear, whether the duration has been specified in the form date-time "/" date-time or date-time "/" dur-value. The difference is relevant, because the different rules apply on how to deal with DST changes.

A related problem is described in #564, i.e. the duration value is lost if the time component equals midnight.

@axunonb
Copy link
Collaborator

axunonb commented Oct 13, 2024

Please double-check the new version merged with #595

@axunonb axunonb closed this as completed Oct 13, 2024
@minichma
Copy link
Collaborator Author

@axunonb The problem still exists!

Btw, appreciate a lot that life is coming back to this project! :-)

@minichma
Copy link
Collaborator Author

@axunonb Reopen this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants