-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coil model, plus validation and example #1549
Conversation
@Mathadon This is ready on my end. Would you want to do the review? |
@AntoineGautier I will do the review. It may take a few days, though! |
Just a remark: This model relies on a dew point calculation and a wet bulb temperature calculation. Both result in an algebraic loop. If we would reimplement those functions then this model could possibly require less computation time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I did not review all model equations in detail again. I presume they are correct since the results look ok. Some minor suggestions in my review. Thanks!
Co-authored-by: Filip Jorissen <[email protected]>
…bpsa into issue1109_wetCoilEpsNTU
@Mathadon Thanks for the review! I addressed your comments in my last commits and left unresolved the major ones for you to double check. |
I think that all issues are resolved. This can be merged as far as I am concerned. |
This is ready to merge once the CI tests pass and the changes in lbl-srg/modelica-buildings#2780 (review) are accepted by @mwetter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge after the CI tests pass.
This closes #1109.
Note that the original validation model in Buildings
Buildings.Fluid.HeatExchangers.Validation.WetCoilEffectivenessNTU
usesBuildings.Fluid.HeatExchangers.WetCoilCounterFlow
as a reference.That reference was removed in this PR to avoid merging the latter model that does not exist in IBPSA.
When simulating the validation model, the user has no other way than looking at the referenced publication to check the model accuracy.
EDIT: For reference, I also include here the links to the review in MBL that shows the parts of the code that are duplicated from existing classes and which would benefit from a refactoring: see lbl-srg/modelica-buildings#2364 (comment) and lbl-srg/modelica-buildings#2364 (comment).