You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The weather data reader outputs currently automatically repeat themselves after one year, even if the table contains more data because of the use of IBPSA.BoundaryConditions.WeatherData.BaseClasses.ConvertTime.
This means that weather data files containing more than 1 year of data will discard the data that comes after 3.15e7 seconds and jump back to the start of the file. Furthermore, weather data files that use an epoch time stamp as the time index simply do not work.
This puts constraints on how the data reader can be used. The reason for this is not clear to me. I propose to remove this block and to use CombiTimeTable instead of CombiTimeTable1Ds. This also has more options for events, interpolation and extrapolation. The impact on events, accuracy and simulation time should however be checked.
The text was updated successfully, but these errors were encountered:
@Mathadon, could you have a look if https://github.com/ibpsa/modelica-ibpsa/tree/issue842_multiyear solves your problem? I don't know if it still uses CombiTimeTable1Ds or CombiTimeTable instead or if there were any reasons to take whatever is in there.
If you see further need for modifications, feel free to work on that branch. I will clean up the examples for testing.
I suggest to close this issue and take the discussions to #842.
The weather data reader outputs currently automatically repeat themselves after one year, even if the table contains more data because of the use of
IBPSA.BoundaryConditions.WeatherData.BaseClasses.ConvertTime
.This means that weather data files containing more than 1 year of data will discard the data that comes after 3.15e7 seconds and jump back to the start of the file. Furthermore, weather data files that use an epoch time stamp as the time index simply do not work.
This puts constraints on how the data reader can be used. The reason for this is not clear to me. I propose to remove this block and to use
CombiTimeTable
instead ofCombiTimeTable1Ds
. This also has more options for events, interpolation and extrapolation. The impact on events, accuracy and simulation time should however be checked.The text was updated successfully, but these errors were encountered: