Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyclic weather data reader #1038

Closed
Mathadon opened this issue Sep 28, 2018 · 4 comments
Closed

cyclic weather data reader #1038

Mathadon opened this issue Sep 28, 2018 · 4 comments
Assignees

Comments

@Mathadon
Copy link
Member

The weather data reader outputs currently automatically repeat themselves after one year, even if the table contains more data because of the use of IBPSA.BoundaryConditions.WeatherData.BaseClasses.ConvertTime.

This means that weather data files containing more than 1 year of data will discard the data that comes after 3.15e7 seconds and jump back to the start of the file. Furthermore, weather data files that use an epoch time stamp as the time index simply do not work.

This puts constraints on how the data reader can be used. The reason for this is not clear to me. I propose to remove this block and to use CombiTimeTable instead of CombiTimeTable1Ds. This also has more options for events, interpolation and extrapolation. The impact on events, accuracy and simulation time should however be checked.

@Mathadon Mathadon self-assigned this Sep 28, 2018
@mlauster
Copy link
Member

mlauster commented Jan 8, 2019

@Mathadon, can this be solved in one step together with #842? Both topics might intefer.

@Mathadon
Copy link
Member Author

Mathadon commented Jan 8, 2019

@mlauster indeed, this looks related. How do you propose to proceed?

@mlauster
Copy link
Member

mlauster commented Jan 8, 2019

@Mathadon, could you have a look if https://github.com/ibpsa/modelica-ibpsa/tree/issue842_multiyear solves your problem? I don't know if it still uses CombiTimeTable1Ds or CombiTimeTable instead or if there were any reasons to take whatever is in there.
If you see further need for modifications, feel free to work on that branch. I will clean up the examples for testing.
I suggest to close this issue and take the discussions to #842.

@mwetter
Copy link
Contributor

mwetter commented May 28, 2019

Closed as it is on the master branch.

@mwetter mwetter closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants