Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions from upstream OpenJDK running on PRs #238

Open
AdamBrousseau opened this issue Oct 13, 2020 · 1 comment
Open

Github actions from upstream OpenJDK running on PRs #238

AdamBrousseau opened this issue Oct 13, 2020 · 1 comment

Comments

@AdamBrousseau
Copy link
Collaborator

Seems OpenJDK added Github actions to their repo recently

https://github.com/ibmruntimes/openj9-openjdk-jdk/commits/openj9/.github/workflows/submit.yml

This will cause these checks to run on our PRs.
Few options to take

  1. Disable GitHub actions complete on our repo(s)
  2. Remove the file from the OpenJ9 branch. Will likely cause merge conflicts every time they update the file(s)
  3. Fix the file so it works for OpenJ9 build/test. This will cause merge conflicts less often than removing the file completely.
@pshipton
Copy link
Member

I'd like to try option 3 first, fix the builds so they can build Openj9 (fetch openj9 source, configure with freemarker), and then see how we do on the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants