New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace getXXX() functions by ES5 getters #11

Open

cjolif opened this issue May 20, 2014 · 2 comments

Labels

Contributor

cjolif commented May 20, 2014

We still do have a few getXXX() function that are just here to return a value aggregated from other values (or queried in sub objects). From a pure ES5 logic they probably should be ES5 getters instead of getXXX() methods?

cjolif added the question label

Member

wkeese commented May 24, 2014

I guess so.

I looked over delite, and saw two candidates:

Widget.getChildren() is hard to change, because it looks in this.containerNode as opposed to this.children which looks under this. So it can't be renamed to this.children but maybe this.widgetChildren or something?
I suppose Widget.getParent() could be renamed to Widget.parentWidget.

Contributor Author

cjolif commented Jan 22, 2015

Looks like this cross-project item is not very useful. Maybe we should just close it and open items on the projects if we found some actual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment