Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup: remove wrapper? #299

Open
wkeese opened this issue Sep 29, 2014 · 0 comments
Open

popup: remove wrapper? #299

wkeese opened this issue Sep 29, 2014 · 0 comments

Comments

@wkeese
Copy link
Member

wkeese commented Sep 29, 2014

As mentioned in #266, consider removing popup's wrapper node completely, and just position the popup itself.

That would also resolve a weirdness where both the popup and popup wrapper have either aria-label or aria-labelledby defined, which seems redundant. It also (currently) doesn't work well when the popup defines aria-labelledby instead of aria-label: the popup wrapper still defines aria-label.

Note: Currently we need to keep the wrapper to support IE11, due to flexbox bugs when the popup is display:flex. The workaround is to encase the popup in another display:flex node.

@wkeese wkeese changed the title popup: remove wrapper popup: remove wrapper? Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant