You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in #266, consider removing popup's wrapper node completely, and just position the popup itself.
That would also resolve a weirdness where both the popup and popup wrapper have either aria-label or aria-labelledby defined, which seems redundant. It also (currently) doesn't work well when the popup defines aria-labelledby instead of aria-label: the popup wrapper still defines aria-label.
Note: Currently we need to keep the wrapper to support IE11, due to flexbox bugs when the popup is display:flex. The workaround is to encase the popup in another display:flex node.
The text was updated successfully, but these errors were encountered:
wkeese
changed the title
popup: remove wrapper
popup: remove wrapper?
Dec 10, 2014
As mentioned in #266, consider removing popup's wrapper node completely, and just position the popup itself.
That would also resolve a weirdness where both the popup and popup wrapper have either
aria-label
oraria-labelledby
defined, which seems redundant. It also (currently) doesn't work well when the popup definesaria-labelledby
instead ofaria-label
: the popup wrapper still definesaria-label
.Note: Currently we need to keep the wrapper to support IE11, due to flexbox bugs when the popup is display:flex. The workaround is to encase the popup in another display:flex node.
The text was updated successfully, but these errors were encountered: