Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLC implementation is affecting existing auth and audit middleware listeners #7

Open
aeweidne opened this issue Aug 2, 2016 · 2 comments

Comments

@aeweidne
Copy link
Contributor

aeweidne commented Aug 2, 2016

With the current NLC implementation, the middleware listeners added by auth and audit are being called for every incoming message, which is more often than before. A secondary problem is that the data passed on the additional events is undefined.

The NLC module implements a catchAll listener (nlc.catchall.js) and a receiveListener (nlc.receive.js).

We need to investigate the best way for these 3 modules to work together.

@ngawor FYI

@aeweidne
Copy link
Contributor Author

aeweidne commented Aug 2, 2016

I doubt catchAll and listener middleware can play nicely together. The "match on everything" approach of catch all doesn't match up well with listener middleware's run-on-match approach.

@ngawor
Copy link
Contributor

ngawor commented Aug 3, 2016

Opened an issue against hubot: hubotio/hubot#1223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants