refactor(impala): remove impala table #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
added
impala
|
Ope, forgot to update the docs. I'll take care of that later. |
|
What impact will this have on Impala backend users, if any? Thanks for exposing tbl_properties. This is useful and I use it in my SQL-based work with Impala. |
gforsyth
force-pushed
the
remove-impala-table
branch
from
94856e0 to
ecb5851
Compare
The only impact on Impala users is the removal of certain methods on the (now removed) |
BREAKING CHANGE: The `ImpalaTable` subclass has been removed. Relevant Impala-specific methods that were on the `ImpalaTable` class have been moved to the `Backend` class, please use those instead (e.g. `con.add_partition` instead of `table.add_partition`).
gforsyth
force-pushed
the
remove-impala-table
branch
from
ecb5851 to
1111a90
Compare
This was referenced Dec 5, 2024
gforsyth
added a commit
that referenced
this pull request
Dec 6, 2024
## Description of changes Followup to #9840 -- updates the Impala backend docs to remove references to the (now removed) table methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
ImpalaTablesubclass. Relevant methods that were on that class have been moved to theBackendclass instead.We used to have backend-specific subclasses of
Tablethat added some backend-specific methods. Most of those were removed in prior releases,ImpalaTablewas the last remaining one.As this is a breaking change, we should hold off on merging this until we're ready to start prepping for a 10.0 release. Depends on #9839.
Fixes #9365.