Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove IntegerValue.label() #9612

Closed
NickCrews opened this issue Jul 16, 2024 · 1 comment · Fixed by #10595
Closed

feat: remove IntegerValue.label() #9612

NickCrews opened this issue Jul 16, 2024 · 1 comment · Fixed by #10595
Labels
breaking change Changes that introduce an API break at any level refactor Issues or PRs related to refactoring the codebase
Milestone
10.0

Comments

@NickCrews
Copy link
Contributor

NickCrews commented Jul 16, 2024 •
edited by jcrist
Loading

Putting this up for tracking it, not immediately actionable.

Once #9096 lands then I think we should remove the IntegerValue.label(labels, nulls) method. Users can easily switch to val.cases(*enumerate(labels), else_=nulls), and we can have this pointer in the deprecation notice.

Originally posted by @NickCrews in #9096 (comment)
@NickCrews NickCrews mentioned this issue Jul 16, 2024
Merged
@cpcloud
Copy link
Member

cpcloud commented Jul 16, 2024

Seems reasonable!

@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase breaking change Changes that introduce an API break at any level labels Jul 16, 2024
@jcrist jcrist added this to the 10.0 milestone Jul 22, 2024
@cpcloud cpcloud mentioned this issue Dec 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that introduce an API break at any level refactor Issues or PRs related to refactoring the codebase
Projects
Ibis planning and roadmap
Status: done
Milestone
10.0
Development

Successfully merging a pull request may close this issue.

refactor(api): remove IntegerValue.label cpcloud/ibis
3 participants
@cpcloud @jcrist @NickCrews