perf(dask): avoid unnecessary calls to compute for cov/corr/argmin/argmax
#9015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the dask backend no longer supports `cov`/`corr` with `how="pop"`.
cpcloud
approved these changes
Apr 18, 2024
cpcloud
added
performance
|
Hm, looks like some failures made it through 🤔 |
|
Weird. I clicked "enable auto-merge", wouldn't have expected that to merge if CI wasn't completely green. |
|
Yep, looking into it. |
|
For some reason the This is a hairy part of GHA that is both hard to reason about and test 😬 |
cpcloud
added a commit
that referenced
this pull request
Apr 19, 2024
I _think_ this should prevent weird merge-even-though-the-things-failed problems observed in #9015.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids calling
computewhen executingcov/corr/argmin/argmax.This necessarily drops support for
cov/corrwithhow="pop", since dask doesn't include native support (yet).Fixes #8187.