Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow *arg syntax with GroupedTable methods #8923

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

NickCrews
Copy link
Contributor

this brings it in line with the normal Table methods

@NickCrews NickCrews changed the title feat: allow *arg sytax with GroupedTable methods feat: allow *arg syntax with GroupedTable methods Apr 10, 2024
this brings it in line with the normal Table methods
@NickCrews
Copy link
Contributor Author

NickCrews commented Apr 11, 2024

It looks to me like the dask failures are flakes unrelated to this PR? I couldn't repro locally with just ci-check -m dask --numprocesses auto --dist=loadgroup (Im on macOS, not ubuntu like the failures, so maybe that's an issue), and looking at the stacktrace it looks like the error is entirely within dask code, it never even touches ibis code.

rebasing on main with no changes to see if it happens again....

@cpcloud
Copy link
Member

cpcloud commented Apr 11, 2024

I think you were hitting the 3.11.9 issue in upstream dask. That was addressed yesterday in #8919 .

@cpcloud cpcloud added this to the 9.0 milestone Apr 11, 2024
@cpcloud cpcloud added feature Features or general enhancements ux User experience related issues labels Apr 11, 2024
@cpcloud cpcloud changed the title feat: allow *arg syntax with GroupedTable methods feat(api): allow *arg syntax with GroupedTable methods Apr 11, 2024
@cpcloud cpcloud enabled auto-merge (squash) April 11, 2024 18:07
@cpcloud cpcloud merged commit 489bb89 into ibis-project:main Apr 11, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants