Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clickhouse): use backwards compatible string search function #8822

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 28, 2024

Makes our implementation of string find and substring operations backwards compatible with clickhouse 23.

@cpcloud cpcloud added this to the 9.0 milestone Mar 28, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend labels Mar 28, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Mar 28, 2024

I cherry-picked this onto #8809 locally and the related tests pass.

@cpcloud cpcloud enabled auto-merge (rebase) March 28, 2024 23:27
@cpcloud cpcloud merged commit bb736fe into ibis-project:main Mar 28, 2024
86 checks passed
@cpcloud cpcloud deleted the clickhouse-avoid-locate branch March 28, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants