Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ibis broken in nixpkgs, might be fixed by a new tag that incorporates the update to sqlglot dependency #8800

Closed
1 task done
ElleNajt opened this issue Mar 27, 2024 · 2 comments
Labels
bug Incorrect behavior inside of ibis

Comments

@ElleNajt
Copy link

What happened?

The most recent tag of ibis is broken in nixpkgs unstable, since it requires sqlglot<=20.11,>=18.12.0 but sqlglot in nixpkgs has been updated to 21.

It seems that more recent commits of ibis upgraded all the way to 23: NixOS/nixpkgs@fc7168d

Would it be possible to release a new tag of ibis incorporating the sqlglot upgrade, so that (hopefully) sqlglot and ibis could both be upgraded to a state where ibis builds?

Also discussed this here: NixOS/nixpkgs@fc7168d#commitcomment-140226400

What version of ibis are you using?

8.0.0

What backend(s) are you using, if any?

No response

Relevant log output

error: builder for '/nix/store/rh3bjhhznv03p438yph1sxmj4yp0k9gq-python3.11-ibis-framework-8.0.0.drv' failed with exit code 1;
       last 10 log lines:
       > Creating a wheel...
       > * Getting build dependencies for wheel...
       > * Building wheel...
       > Successfully built ibis_framework-8.0.0-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for ibis_framework-8.0.0-py3-none-any.whl
       >   - sqlglot<=20.11,>=18.12.0 not satisfied by version 21.1.1
       For full logs, run 'nix-store -l /nix/store/rh3bjhhznv03p438yph1sxmj4yp0k9gq-python3.11-ibis-framework-8.0.0.drv'.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cpcloud
Copy link
Member

cpcloud commented Mar 28, 2024

Thanks for the issue.

We have a fairly big release coming up and we still have a few kinks to work out. Hard to say exactly what the timeline is more specifically than "soon" :)

I hope that in the next few weeks we can cut a release.

@cpcloud
Copy link
Member

cpcloud commented Aug 10, 2024

Seems at least 9.1 is out in nixpkgs, closing.

@cpcloud cpcloud closed this as completed Aug 10, 2024
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis
Projects
Archived in project
Development

No branches or pull requests

2 participants