Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(common): improve the performance of replacing nodes using mappings #8638

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Mar 12, 2024

Mitigate the performance overhead of signature binding during node reconstruction.

Benchmark showing ~20% improvement:

------------------------------------------------------------------------------ benchmark 'test_replace_mapping': 2 tests ------------------------------------------------------------------------------
Name (time in ms)                           Min                Max               Mean            StdDev             Median               IQR            Outliers      OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_replace_mapping (0412_b5f9bbe)     10.6952 (1.17)     31.7057 (1.04)     12.0816 (1.20)     3.2477 (1.0)      11.6603 (1.22)     0.2742 (1.0)          2;15  82.7706 (0.84)         70           1
test_replace_mapping (NOW)               9.1150 (1.0)      30.4098 (1.0)      10.1019 (1.0)      3.4524 (1.06)      9.5369 (1.0)      0.3219 (1.17)          2;3  98.9909 (1.0)          72           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

We use this technique heavily for expression rewriting.

@kszucs kszucs self-assigned this Mar 12, 2024
@kszucs kszucs added expressions Issues or PRs related to the expression API performance Issues related to ibis's performance labels Mar 12, 2024
@kszucs kszucs added this to the 9.0 milestone Mar 12, 2024
@kszucs kszucs changed the title perf(common): improve the performance of replacing nodes with mappings perf(common): improve the performance of replacing nodes using mappings Mar 12, 2024
@cpcloud cpcloud enabled auto-merge (squash) March 13, 2024 01:08
@cpcloud cpcloud merged commit a2e733a into ibis-project:main Mar 13, 2024
78 checks passed
@kszucs kszucs deleted the replace-mapping branch March 13, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expressions Issues or PRs related to the expression API performance Issues related to ibis's performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants