Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exasol): add support for ExtractDayOfYear #8578

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat(exasol): add support for ExtractDayOfYear #8578

merged 1 commit into from
Mar 7, 2024

Conversation

Nicoretti
Copy link
Contributor

Description of changes

Add implementation for ExtractDayOfYear to Exasol backend

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@cpcloud cpcloud added this to the 9.0 milestone Mar 7, 2024
@cpcloud cpcloud added feature Features or general enhancements exasol Issues related to the exasol backend labels Mar 7, 2024
@cpcloud cpcloud enabled auto-merge (squash) March 7, 2024 15:16
auto-merge was automatically disabled March 7, 2024 15:32

Head branch was pushed to by a user without write access

@Nicoretti
Copy link
Contributor Author

@cpcloud I've just rebased and simplified the implementation

ibis/backends/exasol/compiler.py Outdated Show resolved Hide resolved
@Nicoretti Nicoretti requested a review from cpcloud March 7, 2024 16:05
@cpcloud cpcloud merged commit df2b69e into ibis-project:main Mar 7, 2024
74 checks passed
@Nicoretti Nicoretti deleted the feature/exasol-day-of-year branch March 8, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exasol Issues related to the exasol backend feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants