Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flink): implement support for array expansion #8511

Merged
merged 5 commits into from
Apr 12, 2024
Merged

feat(flink): implement support for array expansion #8511

merged 5 commits into from
Apr 12, 2024

Conversation

chloeh13q
Copy link
Contributor

Description of changes

Implements support for array expansion.

Issues closed

Resolves #8457

@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch from dc234ca to 2a763ca Compare March 1, 2024 09:41
@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch 2 times, most recently from a76ad22 to e815105 Compare March 1, 2024 22:24
@chloeh13q chloeh13q marked this pull request as ready for review March 1, 2024 22:56
@chloeh13q chloeh13q requested a review from cpcloud March 5, 2024 15:54
@chloeh13q chloeh13q mentioned this pull request Mar 6, 2024
Closed
1 task
@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch from e815105 to d6cb806 Compare March 21, 2024 00:00
@chloeh13q chloeh13q requested a review from cpcloud March 21, 2024 02:59
@chloeh13q
Copy link
Contributor Author

Will rebase to main after we merge #8751 to resolve a couple of tests marked as broken.

@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch 3 times, most recently from d9b2955 to 2ab0544 Compare March 27, 2024 22:57
@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch from 2ab0544 to 6a618c8 Compare March 27, 2024 22:58
@chloeh13q chloeh13q force-pushed the feat/flink-array-expansion branch from 6a618c8 to 7697440 Compare March 27, 2024 23:01
@chloeh13q
Copy link
Contributor Author

@cpcloud Hey Philip - I merged #8751 that fixed the compilation of memtables with nested data. I then rebased and updated the broken tests. Would you mind taking another look at the PR? Thanks

cpcloud
cpcloud approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to go for now, we'll have to keep an eye on the complexity of the impl here.

@cpcloud cpcloud merged commit a6e6564 into ibis-project:main Apr 12, 2024
82 checks passed
@cpcloud cpcloud added this to the 9.0 milestone Apr 12, 2024
@cpcloud cpcloud added feature Features or general enhancements flink Issues or PRs related to Flink labels Apr 12, 2024
@chloeh13q chloeh13q deleted the feat/flink-array-expansion branch April 12, 2024 17:43
@chloeh13q chloeh13q mentioned this pull request Apr 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
feature Features or general enhancements flink Issues or PRs related to Flink
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

feat(flink): implement array expansion for Flink backend
2 participants
@chloeh13q @cpcloud