Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: new dask 2022.4.2 release triggers test error due to warning #8375

Closed
ncclementi opened this issue Feb 16, 2024 · 1 comment
Closed
Assignees

Comments

@ncclementi
Copy link
Contributor

While working on #8371 I tried to run pytest -m core and hit an error because the environment pulled dask=2024.4.2. I believe this is because we raise when we have warnings?.

SHould we pin dask to be < 2024.4.2 or is there a better solution here?

______________________________________________ ERROR collecting ibis/expr/tests/test_schema.py ______________________________________________
ibis/expr/tests/test_schema.py:26: in <module>
    import dask.dataframe as dd  # noqa: F401
/Users/naty/mambaforge/envs/ibis-dev-arm64/lib/python3.10/site-packages/dask/dataframe/__init__.py:162: in <module>
    warnings.warn(
E   DeprecationWarning: The current Dask DataFrame implementation is deprecated. 
E   In a future release, Dask DataFrame will use new implementation that
E   contains several improvements including a logical query planning.
E   The user-facing DataFrame API will remain unchanged.
E   
E   The new implementation is already available and can be enabled by
E   installing the dask-expr library:
E   
E       $ pip install dask-expr
E   
E   and turning the query planning option on:
E   
E       >>> import dask
E       >>> dask.config.set({'dataframe.query-planning': True})
E       >>> import dask.dataframe as dd
E   
E   API documentation for the new implementation is available at
E   https://docs.dask.org/en/stable/dask-expr-api.html
E   
E   Any feedback can be reported on the Dask issue tracker
E   https://github.com/dask/dask/issues
========================================================== short test summary info ==========================================================
ERROR ibis/expr/tests/test_schema.py - DeprecationWarning: The current Dask DataFrame implementation is deprecated. 
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
@cpcloud
Copy link
Member

cpcloud commented Feb 16, 2024

Fixed in #8371.

@cpcloud cpcloud closed this as completed Feb 16, 2024
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Feb 16, 2024
@ncclementi ncclementi self-assigned this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants