fix(polars): columns are picked from the correct side in case of conflicting names #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
added
tests
kszucs
force-pushed
the
test-join-column-renaming
branch
from
b3dd7d0 to
ccd9277
Compare
|
If I remember correctly this also required upstream changes in polars -- do we want to bump the lower bound of supported polars versions to pick up the required change? I'll track down that issue... |
|
oh, it's linked in #7345 -- but also, it doesn't look like it has been fixed upstream yet (although they plan to). |
kszucs
force-pushed
the
the-epic-split
branch
2 times, most recently
from
3376022 to
432d151
Compare
|
I am rebasing this now. |
cpcloud
force-pushed
the
test-join-column-renaming
branch
from
ccd9277 to
f8d947c
Compare
cpcloud
approved these changes
Feb 2, 2024
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 4, 2024
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 5, 2024
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
cpcloud
pushed a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been already fixed by the rewrite converting the join chain to pairwise join operations, so this only adds a test case.
Fixes #7345
Depends on #8127