Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce watermarks in ibis api #7127

Merged
merged 1 commit into from
Sep 12, 2023
Merged

feat: introduce watermarks in ibis api #7127

merged 1 commit into from
Sep 12, 2023

Conversation

chloeh13q
Copy link
Contributor

@chloeh13q chloeh13q commented Sep 12, 2023 •
edited
Loading

Introduce watermarks in Ibis API and implements CREATE TABLE DDL with optional watermark strategy definition in Flink backend.

@chloeh13q chloeh13q force-pushed the feat/watermark branch 2 times, most recently from f027f0a to b9d747a Compare September 12, 2023 18:00
@chloeh13q chloeh13q marked this pull request as ready for review September 12, 2023 18:31
jcrist
jcrist reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM! Just a few small nits.

ibis/expr/streaming.py Outdated Show resolved Hide resolved
ibis/expr/api.py Outdated Show resolved Hide resolved
@chloeh13q
Copy link
Contributor Author

@jcrist Thanks! Addressed the comments

jcrist
jcrist approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jcrist jcrist enabled auto-merge (rebase) September 12, 2023 21:17
@jcrist jcrist merged commit eaaebb8 into ibis-project:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrist jcrist jcrist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chloeh13q @jcrist