-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(register): remove deprecated register method #10545
Conversation
BREAKING CHANGE: The deprecated `register` method has been removed. Please use the file-specific `read_*` methods instead. For in-memory objects, pass them to `ibis.memtable` or `create_table`.
9b4c11f
to
795214d
Compare
Hmm, so the I recognize the convenience here, but it's also against our general push towards requiring explicit table creation. Do we rip that out, too? Or leave in |
Thank you for prepping this!
That's tricky. I can't imagine it's used too widely, but I vote to leave it there if anyone uses that functionality with the DataFusion backend today. Could we mark it deprecated and for the |
Thanks, @IndexSeek ! This seemed like a good suggestion, so I've remove the public |
2c03518
to
9ff388c
Compare
9ff388c
to
e73b481
Compare
189c2e5
to
af8085d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it
refactor(register): remove deprecated register method
BREAKING CHANGE: The deprecated
register
method has been removed.Please use the file-specific
read_*
methods instead. For in-memoryobjects, pass them to
ibis.memtable
orcreate_table
.Description of changes
The
register
method is removed everywhere. Test files have been renamed totest_io.py
instead oftest_register.py
, or they have been removed entirelybecause they are duplicates of tests in
test_client.py
or elsewhere.Issues closed
#10175