feat(export): implement the Column.to_list() API
#10498
Conversation
|
|
ibis/expr/types/generic.py
Outdated
| >>> t.bill_length_mm.to_list() | ||
| [39.1, 39.5, 40.3, None, 36.7] | ||
| """ | ||
| return self.to_pyarrow().to_pylist() |
There was a problem hiding this comment.
The kwargs need to be passed through to to_pyarrow here
There was a problem hiding this comment.
Ah, true, and docstring should say same as kwargs for to_pyarrow, too.
There was a problem hiding this comment.
Wonder why the test is passing...
I'll take a look.
There was a problem hiding this comment.
Wonder why the test is passing...
The test logic was wrong; fixed in fe03b1d.
deepyaman
force-pushed
the
feat/column-to-list
branch
from
e3d0d24 to
fe03b1d
Compare
| Parameters | ||
| ---------- | ||
| kwargs | ||
| Same as keyword arguments to [`to_pyarrow`](#ibis.expr.types.core.Expr.to_pyarrow) |
There was a problem hiding this comment.
This is technically a broken link, since the docs aren't published... but so is
[`execute`]((#ibis.expr.types.core.Expr.execute)
used elsewhere.
There was a problem hiding this comment.
Not sure if want to start publishing the docs so the links work? A linkchecker might be nice at some point. :D
There was a problem hiding this comment.
We have a link checker -- maybe it doesn't work on quartodoc-generated links? But yeah, lychee is the link checker and there's a checklinks rule in the justfile, so I dunno.
There was a problem hiding this comment.
Ah, interesting, we do publish Column docs, but not inherited methods, so we're missing out on things like to_pyarrow.
Well, that's a separate concern
Description of changes
Implement
Column.to_list()convenience method to avoid having to doColumn.to_pyarrow().to_pylist()manually.Issues closed