Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datafusion): raise when attempting to create temp table #10072

Merged
merged 6 commits into from
Sep 10, 2024
Merged

fix(datafusion): raise when attempting to create temp table #10072

merged 6 commits into from
Sep 10, 2024

Conversation

ncclementi
Copy link
Contributor

Closes: #10069

@ncclementi ncclementi requested a review from cpcloud September 9, 2024 21:42
cpcloud
cpcloud requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit in the error message.

ibis/backends/datafusion/__init__.py Outdated Show resolved Hide resolved
ibis/backends/datafusion/tests/test_register.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_client.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_client.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added the datafusion The Apache DataFusion backend label Sep 10, 2024
@cpcloud cpcloud added this to the 9.5 milestone Sep 10, 2024
@cpcloud cpcloud merged commit 1cf5439 into ibis-project:main Sep 10, 2024
81 checks passed
@ncclementi ncclementi deleted the datafusion-patch branch September 10, 2024 17:40
gforsyth added a commit to gforsyth/ibis that referenced this pull request Sep 11, 2024
@gforsyth
Revert "fix(datafusion): raise when attempting to create temp table (i…
d01a36a 
…bis-project#10072)"

This reverts commit 1cf5439.
cpcloud pushed a commit that referenced this pull request Sep 11, 2024
@gforsyth
revert: fix(datafusion): raise when attempting to create temp table (#…
d48a575 
…10072) (#10099)
ncclementi added a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
@ncclementi @cpcloud
fix(datafusion): raise when attempting to create temp table (ibis-pro…
f9b905b 
…ject#10072)

Co-authored-by: Phillip Cloud <[email protected]>
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
@gforsyth @ncclementi
revert: fix(datafusion): raise when attempting to create temp table (i…
c3a7481 
…bis-project#10072) (ibis-project#10099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
datafusion The Apache DataFusion backend
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.

bug(datafusion): raise on create_datable when temp=True
2 participants
@ncclementi @cpcloud