Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): allow setting auto_detect to False by fixing translation of columns argument #10065

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 9, 2024

Fixes translation of the columns argument to read_json. Reported in this Zulip thread.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title read json columns argument fix(duckdb): allow setting auto_detect to False by fixing translation of columns argument Sep 9, 2024
@cpcloud cpcloud requested a review from gforsyth September 9, 2024 11:55
@cpcloud cpcloud added bug Incorrect behavior inside of ibis duckdb The DuckDB backend labels Sep 9, 2024
@cpcloud cpcloud added this to the 9.5 milestone Sep 9, 2024
@cpcloud cpcloud merged commit 883d2d3 into ibis-project:main Sep 9, 2024
85 checks passed
@cpcloud cpcloud deleted the read-json-columns-argument branch September 9, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants