From e82aebf4acd19036a3efda44e0bfa13a3120b679 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Sun, 26 May 2024 11:13:40 -0400 Subject: [PATCH] test(clickhouse): xfail on broken sqlglot functionality --- .../backends/clickhouse/tests/test_datatypes.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/ibis/backends/clickhouse/tests/test_datatypes.py b/ibis/backends/clickhouse/tests/test_datatypes.py index b784ceb224ef..103f32aa64d6 100644 --- a/ibis/backends/clickhouse/tests/test_datatypes.py +++ b/ibis/backends/clickhouse/tests/test_datatypes.py @@ -3,7 +3,9 @@ import hypothesis as h import hypothesis.strategies as st import pytest +import sqlglot as sg import sqlglot.expressions as sge +from packaging.version import parse as vparse from pytest import param import ibis @@ -192,6 +194,11 @@ def test_array_discovery_clickhouse(con): ), nullable=False, ), + marks=pytest.mark.xfail( + vparse(sg.__version__) == vparse("24.0.0"), + reason="struct parsing for clickhouse broken in sqlglot 24", + raises=sg.ParseError, + ), id="named_tuple", ), param( @@ -203,6 +210,11 @@ def test_array_discovery_clickhouse(con): ), nullable=False, ), + marks=pytest.mark.xfail( + vparse("24.0.0") <= vparse(sg.__version__) <= vparse("24.0.1"), + reason="struct parsing for clickhouse broken in sqlglot 24", + raises=sg.ParseError, + ), id="unnamed_tuple", ), param( @@ -214,6 +226,11 @@ def test_array_discovery_clickhouse(con): ), nullable=False, ), + marks=pytest.mark.xfail( + vparse("24.0.0") <= vparse(sg.__version__) <= vparse("24.0.1"), + reason="struct parsing for clickhouse broken in sqlglot 24", + raises=sg.ParseError, + ), id="partially_named", ), param(