From dd1be07e15653473248ec1efb9df35a77b86b786 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Mon, 24 Jun 2024 08:20:16 -0400 Subject: [PATCH] Apply suggestions from code review --- ibis/backends/dask/executor.py | 2 +- ibis/backends/pandas/executor.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ibis/backends/dask/executor.py b/ibis/backends/dask/executor.py index 660d75a8c1105..94d4f7c6ffa40 100644 --- a/ibis/backends/dask/executor.py +++ b/ibis/backends/dask/executor.py @@ -371,7 +371,7 @@ def visit(cls, op: ops.Sort, parent, keys): elif not any(nulls_first): na_position = "last" else: - raise ValueError("dask does not support different columns ordering") + raise ValueError("dask does not support specifying null ordering for individual columns") newcols = {gen_name("sort_key"): col for col in keys} names = list(newcols.keys()) diff --git a/ibis/backends/pandas/executor.py b/ibis/backends/pandas/executor.py index 0a81024340746..6e7ddf27700ff 100644 --- a/ibis/backends/pandas/executor.py +++ b/ibis/backends/pandas/executor.py @@ -600,7 +600,7 @@ def visit(cls, op: ops.Sort, parent, keys): elif not any(nulls_first): na_position = "last" else: - raise ValueError("pandas does not support different columns ordering") + raise ValueError("pandas does not support specifying null ordering for individual columns") newcols = {gen_name("sort_key"): col for col in keys} names = list(newcols.keys())