From d174f3ef80cf183db61c0cb211c18a1e277e0f6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kriszti=C3=A1n=20Sz=C5=B1cs?= Date: Thu, 14 Dec 2023 14:52:54 +0100 Subject: [PATCH] chore(ci): add todo note about restoring the previous ci-check command --- .github/workflows/ibis-main.yml | 1 + ibis/backends/base/sql/__init__.py | 5 +++-- ibis/backends/pandas/core.py | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ibis-main.yml b/.github/workflows/ibis-main.yml index e4c0de69dfab3..befd7dde6c9ee 100644 --- a/.github/workflows/ibis-main.yml +++ b/.github/workflows/ibis-main.yml @@ -94,6 +94,7 @@ jobs: - name: run all core tests and run benchmarks once parallel if: matrix.os != 'windows-latest' + # TODO(kszucs): restore "just ci-check -m "'core or benchmark'" -n auto" run: poetry run pytest -v -n auto ibis/common ibis/expr ibis/tests ibis/formats - name: run all core tests and run benchmarks once serial diff --git a/ibis/backends/base/sql/__init__.py b/ibis/backends/base/sql/__init__.py index cebfe6eac3a19..f1dbadaa714d9 100644 --- a/ibis/backends/base/sql/__init__.py +++ b/ibis/backends/base/sql/__init__.py @@ -92,8 +92,9 @@ def table(self, name: str, database: str | None = None) -> ir.Table: ) qualified_name = self._fully_qualified_name(name, database) schema = self.get_schema(qualified_name) - namespace = ops.Namespace(database=database) - node = ops.DatabaseTable(name, schema, self, namespace=namespace) + node = ops.DatabaseTable( + name, schema, self, namespace=ops.Namespace(database=database) + ) return node.to_expr() def _fully_qualified_name(self, name, database): diff --git a/ibis/backends/pandas/core.py b/ibis/backends/pandas/core.py index 50ae12d30b2ef..ef29b2bb29cc6 100644 --- a/ibis/backends/pandas/core.py +++ b/ibis/backends/pandas/core.py @@ -135,7 +135,6 @@ if TYPE_CHECKING: from collections.abc import Iterable, Mapping - integer_types = np.integer, int floating_types = (numbers.Real,) numeric_types = integer_types + floating_types