From b461b4cda5950d2d62b24a089f1aeb023e7104ef Mon Sep 17 00:00:00 2001 From: Nick Crews Date: Tue, 29 Oct 2024 12:16:13 -0800 Subject: [PATCH] chore(flink): remove xfails now that flink passes --- ibis/backends/tests/test_numeric.py | 41 ----------------------------- 1 file changed, 41 deletions(-) diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py index d028ea15721b..70721ba17113 100644 --- a/ibis/backends/tests/test_numeric.py +++ b/ibis/backends/tests/test_numeric.py @@ -1099,7 +1099,6 @@ def test_binary_arithmetic_operations(backend, alltypes, df, op): backend.assert_series_equal(result, expected, check_exact=False) -@pytest.mark.notimpl("flink", raises=AssertionError, reason="Flink does floor division") def test_integer_truediv(con): expr = 1 / ibis.literal(2) result = con.execute(expr) @@ -1149,11 +1148,6 @@ def test_floating_mod(backend, alltypes, df): raises=OracleDatabaseError, reason="Oracle doesn't do integer division by zero", ), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1165,11 +1159,6 @@ def test_floating_mod(backend, alltypes, df): raises=OracleDatabaseError, reason="Oracle doesn't do integer division by zero", ), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1181,11 +1170,6 @@ def test_floating_mod(backend, alltypes, df): raises=OracleDatabaseError, reason="Oracle doesn't do integer division by zero", ), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1197,11 +1181,6 @@ def test_floating_mod(backend, alltypes, df): raises=OracleDatabaseError, reason="Oracle doesn't do integer division by zero", ), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param("float_col", 0), @@ -1216,11 +1195,6 @@ def test_floating_mod(backend, alltypes, df): reason="Oracle doesn't do integer division by zero", ), pytest.mark.never(["impala"], reason="doesn't allow divide by zero"), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1233,11 +1207,6 @@ def test_floating_mod(backend, alltypes, df): reason="Oracle doesn't do integer division by zero", ), pytest.mark.never(["impala"], reason="doesn't allow divide by zero"), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1250,11 +1219,6 @@ def test_floating_mod(backend, alltypes, df): reason="Oracle doesn't do integer division by zero", ), pytest.mark.never(["impala"], reason="doesn't allow divide by zero"), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param( @@ -1267,11 +1231,6 @@ def test_floating_mod(backend, alltypes, df): reason="Oracle doesn't do integer division by zero", ), pytest.mark.never(["impala"], reason="doesn't allow divide by zero"), - pytest.mark.notyet( - "flink", - raises=Py4JJavaError, - reason="Flink doesn't do integer division by zero", - ), ], ), param(