From 2ceb7f5399f05692162a11148b5c8204bfa6bf69 Mon Sep 17 00:00:00 2001 From: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Date: Fri, 22 Dec 2023 04:25:47 -0500 Subject: [PATCH] test: add xfail for things that require inner join convenience --- ibis/backends/duckdb/tests/test_client.py | 1 + ibis/backends/tests/test_generic.py | 3 +++ ibis/backends/tests/test_sql.py | 3 +++ 3 files changed, 7 insertions(+) diff --git a/ibis/backends/duckdb/tests/test_client.py b/ibis/backends/duckdb/tests/test_client.py index e01467aa5f65..08cee6fb0954 100644 --- a/ibis/backends/duckdb/tests/test_client.py +++ b/ibis/backends/duckdb/tests/test_client.py @@ -189,6 +189,7 @@ def test_insert(con): assert t.count().execute() == 2 +@pytest.mark.xfail(reason="snowflake backend not yet rewritten") def test_to_other_sql(con, snapshot): pytest.importorskip("snowflake.connector") diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py index 3554309052f9..c643315a6c7f 100644 --- a/ibis/backends/tests/test_generic.py +++ b/ibis/backends/tests/test_generic.py @@ -1016,6 +1016,9 @@ def test_memtable_column_naming_mismatch(backend, con, monkeypatch, df, columns) ibis.memtable(df, columns=columns) +@pytest.mark.xfail( + raises=com.IntegrityError, reason="inner join convenience not implemented" +) @pytest.mark.notimpl( ["dask", "pandas", "polars"], raises=NotImplementedError, reason="not a SQL backend" ) diff --git a/ibis/backends/tests/test_sql.py b/ibis/backends/tests/test_sql.py index bbc3f023410e..9eaa34b7b3de 100644 --- a/ibis/backends/tests/test_sql.py +++ b/ibis/backends/tests/test_sql.py @@ -92,6 +92,9 @@ def test_group_by_has_index(backend, snapshot): snapshot.assert_match(sql, "out.sql") +@pytest.mark.xfail( + raises=exc.IntegrityError, reason="inner join convenience not implemented" +) @pytest.mark.never(["pandas", "dask", "polars", "pyspark"], reason="not SQL") def test_cte_refs_in_topo_order(backend, snapshot): mr0 = ibis.table(schema=ibis.schema(dict(key="int")), name="leaf")