Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action not throwing exitcode anymore #28

Closed
BennyTheSen opened this issue Aug 19, 2021 · 3 comments · Fixed by #29
Closed

Action not throwing exitcode anymore #28

BennyTheSen opened this issue Aug 19, 2021 · 3 comments · Fixed by #29

Comments

@BennyTheSen
Copy link

I used the action previously and it was throwing an exitcode (1) when finding errors with the default parameters for the action.

When I'm running the action at the moment it's not generating an exitcode anymore:

Run ibiqlik/[email protected]
  with:
    strict: true
    format: github
    no_warnings: false
  env:
    tf_version: 1.0.2

======================
= Linting YAML files =
======================
Warning: [truthy] truthy value should be one of [false, true]
Error: [line-length] line too long (86 > 80 characters)
Error: [hyphens] too many spaces after hyphen
Error: syntax error: expected <block end>, but found '<block mapping start>' (syntax)
Warning: [comments-indentation] comment not indented like content

Here is the workflow config:

      - name: "YAML lint"
        uses: ibiqlik/[email protected]
        with:
          strict: true

I tried it with the github and default format, same result.

@ibiqlik
Copy link
Owner

ibiqlik commented Aug 19, 2021

😱 oh my, I'm on it.

@ibiqlik
Copy link
Owner

ibiqlik commented Aug 19, 2021

@BennyTheSen Thanks a lot for reporting it 🙇 It should be fixed now in v3, v3.0 and v3.0.4

@ibiqlik ibiqlik reopened this Aug 19, 2021
@BennyTheSen
Copy link
Author

Yes testet it again with v3, working like intended. Thank you for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants