-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SpeedTripValidator): check for repeated arrival times #11
base: dev
Are you sure you want to change the base?
Conversation
f39b9fd
to
db482fd
Compare
This branch is not compatible with the MTC datatools branch, but I did some funky stuff in 29827a0441a5d0c7e50583a63e0df12b8216b7bd to resolve this. We should still merge this PR for now, but until the datatools MTC branch can handle the latest gifs-lib version, we can use my hack commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the mass import.
src/test/java/com/conveyal/gtfs/validator/SpeedTripValidatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@josh-willis-arcadis once you have two approves you can merge! I don't need to review. |
@br648 We will leave this one open for now until we bring the MTC datatools on par with the main datatools work. |
@br648 @binh-dam-ibigroup I agree lets keep it open. Github won't allow a PR to be merged until there are 3 approving reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Since when has three approves been required?! Anyway, here is the third.
@@ -112,6 +113,12 @@ public void tripTravelingTooSlowWithMissingStopTimesHasError() { | |||
checkFeedHasError(TRAVEL_TOO_SLOW, "6", 3); | |||
} | |||
|
|||
@Test | |||
public void tripHasDuplicateArrivalTimesHasError() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change the name to tripHasDuplicateArrivalTimesError()
and remove public
.
Checklist
dev
before they can be merged tomaster
)Description
Adds an error check for duplicate arrival_times in stop_times.txt for a trip.
Based on the conveyal repo for projects still using that project.