Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SpeedTripValidator): check for repeated arrival times #11

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

josh-willis-arcadis
Copy link

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Adds an error check for duplicate arrival_times in stop_times.txt for a trip.
Based on the conveyal repo for projects still using that project.

@miles-grant-ibigroup miles-grant-ibigroup force-pushed the DT-462-add-stop-time-validator branch from f39b9fd to db482fd Compare November 26, 2024 19:34
@miles-grant-ibigroup
Copy link

miles-grant-ibigroup commented Nov 26, 2024

This branch is not compatible with the MTC datatools branch, but I did some funky stuff in 29827a0441a5d0c7e50583a63e0df12b8216b7bd to resolve this. We should still merge this PR for now, but until the datatools MTC branch can handle the latest gifs-lib version, we can use my hack commit

Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the mass import.

Copy link

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@br648
Copy link

br648 commented Dec 3, 2024

@josh-willis-arcadis once you have two approves you can merge! I don't need to review.

@binh-dam-ibigroup
Copy link

@josh-willis-arcadis once you have two approves you can merge! I don't need to review.

@br648 We will leave this one open for now until we bring the MTC datatools on par with the main datatools work.

@josh-willis-arcadis
Copy link
Author

@br648 @binh-dam-ibigroup I agree lets keep it open. Github won't allow a PR to be merged until there are 3 approving reviews.

Copy link

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. Since when has three approves been required?! Anyway, here is the third.

@@ -112,6 +113,12 @@ public void tripTravelingTooSlowWithMissingStopTimesHasError() {
checkFeedHasError(TRAVEL_TOO_SLOW, "6", 3);
}

@Test
public void tripHasDuplicateArrivalTimesHasError() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change the name to tripHasDuplicateArrivalTimesError() and remove public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants