Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dt 462 add stop times validator #10

Closed

Conversation

josh-willis-arcadis
Copy link

@josh-willis-arcadis josh-willis-arcadis commented Nov 12, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Adds an error check for duplicate arrival_times in stop_times.txt for a trip.

@josh-willis-arcadis
Copy link
Author

First attempt at solving the issues. Need to address tests

Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an error in src/test/resources/real-world-gtfs-feeds/VTA-gtfs-multiple-trips/stop_times.txt, and can you address the failing tests?

Copy link

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should leave this open in case MTC has feedback to give until they approve.

@josh-willis-arcadis
Copy link
Author

This PR is no longer relevant and this logic can be found here: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants