-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dt 462 add stop times validator #10
Conversation
First attempt at solving the issues. Need to address tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an error in src/test/resources/real-world-gtfs-feeds/VTA-gtfs-multiple-trips/stop_times.txt, and can you address the failing tests?
src/test/java/com/conveyal/gtfs/validator/SpeedTripValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/resources/real-world-gtfs-feeds/VTA-gtfs-multiple-trips/stop_times.txt
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/gtfs/validator/SpeedTripValidator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We should leave this open in case MTC has feedback to give until they approve.
This PR is no longer relevant and this logic can be found here: #11 |
Checklist
dev
before they can be merged tomaster
)Description
Adds an error check for duplicate arrival_times in stop_times.txt for a trip.